Worst part is when the un-refactored code continues to confuse other devs, meaning it keeps causing additional work, but you still don’t get time to actually fix it.
Commit1: actual change
Commit2: this code is so misleading and I have to refactor it refactors
Me: painfully rejects PR the story said nothing about refactoring…
The mistake is admitting that you’re refactoring. I just implemented the feature/ fixed the bug. Why did I change so much? The issue was a little underscoped.
The fun thing is to try to force your fellow devs to refactor piecemeal through comments on their pull requests.
Worst part is when the un-refactored code continues to confuse other devs, meaning it keeps causing additional work, but you still don’t get time to actually fix it.
Commit1: actual change
Commit2: this code is so misleading and I have to refactor it refactors
Me: painfully rejects PR the story said nothing about refactoring…
We build our own prisons.
The mistake is admitting that you’re refactoring. I just implemented the feature/ fixed the bug. Why did I change so much? The issue was a little underscoped.
The fun thing is to try to force your fellow devs to refactor piecemeal through comments on their pull requests.